search

kytos-ng / ui

Kytos Admin UI
MIT License
0 stars 3 forks source link

Fix missing vue icons #27

Closed rmotitsuki closed 2 years ago

rmotitsuki commented 2 years ago

Fix issue #21 Updating to the last vue-awesome icon library made some icons to disappear from Kytos UI. This PR fix the issue and many other broken icons. The library split the icons in three different folders, so the naming convention for the icons is different now. The icons with suffix "-o", from outlined, is in a different folder called "regular". Solid icons remained on the root folder. Some icons have different filenames now.

rmotitsuki commented 2 years ago

You can search icons in the Font Awesome website. Unfortunately not all of them are available. You will have to check the vue-awesome repository to find the correct name. Example: Solid gear. name="cog" image Regular/oulined gear. name="regular/cog" image

viniarck commented 2 years ago

You can search icons in the Font Awesome website. Unfortunately not all of them are available. You will have to check the vue-awesome repository to find the correct name. Example: Solid gear. name="cog" image Regular/oulined gear. name="regular/cog" image

@rmotitsuki, got it. So, regarding question 1, do you see any other alternative to still keep compatible with previous icons or is it faster to open issues and PRs on other UIs that are using deprecated icons like gear? Several NApps use this icon when sending notifications

viniarck commented 2 years ago

@rmotitsuki it's really neat this transformation with iconName that you provided, great to have backwards compatibility for the icons that the NApps used the most, with this we won't need extra PRs to update the NApps. Great stuff. Please, feel free to merge this PR and bump the pre-release on GH.