search

kytos-ng / ui

Kytos Admin UI
MIT License
0 stars 3 forks source link

Added Modal Component #80

Closed HeriLFIU closed 2 months ago

HeriLFIU commented 2 months ago

Closes #N/A

Summary

Added a reusable modal component to UI made from existing code. The component is called "k-modal".

image

Local Tests

A combination of all parameters were used all at once to ensure functionality.

Associated Pull Requests

Childs

Description - Repositories that implemented new modal component.

HeriLFIU commented 2 months ago

The new modal component seems to be working fine, at least in the main UI repo. Imma start replacing it within the other napps and do some further testing.

HeriLFIU commented 2 months ago

@viniarck @rmotitsuki Just updated the changelog.

image

The new modal component seems to be working on topology without any issue.

HeriLFIU commented 2 months ago

@viniarck Correct me if I am wrong but I was only able to find 3 other repos that implemented modals within their UI.

It should be these 3:

  1. https://github.com/kytos-ng/telemetry_int/pull/134
  2. https://github.com/kytos-ng/mef_eline/pull/507
  3. https://github.com/kytos-ng/topology/pull/210
HeriLFIU commented 2 months ago

@viniarck scratch that, there are two left, another one in topology and one in maintenance

HeriLFIU commented 2 months ago

I think that I was able to locate every single modal and update it with the new modal component. I attached a link to the corresponding PR's to this PR. All that's left is an additional modal within telemetry_int, but it has an additional check box, so I will have to make modifications to the existing modal component. I also fixed some buttons within the maintenance UI.