kytos / flow_manager

MIT License
1 stars 16 forks source link

API call /flow_manager/v2/flows/{dpid} on DELETE is returning misleading response status #136

Open ArturoQuintana opened 3 years ago

ArturoQuintana commented 3 years ago

@hdiogenes @italovalcy @ajoaoff @rmotitsuki

reflected on the end-to-end test: tests/test_e2e_20_flow_manager.py::TestE2EFlowManager::test_022_delete_flow_should_fail

Code:

def test_022_delete_flow_should_fail(self):
        """Test if the flow deletion process specifying an unknown path behaves as expected (400 Error)."""

        payload = {}

        # delete the flow
        api_url = KYTOS_API + '/flow_manager/v2/flows/00:00:00:00:00:00:00:01'
        response = requests.delete(api_url, data=json.dumps(payload),
                                   headers={'Content-type': 'application/json'})
        assert response.status_code == 400

The same happens with these cases:

payload = {
            "flows": [
            ]
        }

and

payload = {
            "flows": [
                {

                }
            ]
        }

Case:

payload = {
            "flows": [
                {
                    "priority"
                }
            ]
        }

The issue mentioned above should be verified for any not serializable JSON