Check state before deleting or modifying

kytos / maintenance

Kytos Maintenance Window NApp

0 stars 12 forks source link

Check state before deleting or modifying #38

Closed ajoaoff closed 3 years ago

ajoaoff commented 3 years ago

Fix #36

:bookmark_tabs: Description of the Change

Update and delete maintenance now checks the state of the maintenance. If it is running, the procedure is cancelled and an error code is returned.

:computer: Verification Process

Unit test was coded and all unit tests passed

:page_facing_up: Release Notes

Fix an issue where updates and deletes were allowed when the maintenance is running.

ArturoQuintana commented 3 years ago

@ajoaoff @hdiogenes @italovalcy @rmotitsuki After this contribution, a new problem arose related to the Status class. It seems that the retrievement process of all the maintenances, or particular maintenance, returns a 500 error based on the error "Object of type Status is not JSON serializable."

ajoaoff commented 3 years ago

@ArturoQuintana the problem was not introduced in this PR, but in PR #30. It has been fixed in PR #42.