Set OFPPC_NO_FWD flag to unsupported interfaces

kytos / of_core

Kytos Main OpenFlow Network Application (NApp)

MIT License

1 stars 19 forks source link

Set OFPPC_NO_FWD flag to unsupported interfaces #94

Closed gleybersonandrade closed 4 years ago

gleybersonandrade commented 4 years ago

This PR changes the behavior of handle_port_desc method, defining OFPPC_NO_FWD flag to interfaces that kytos should not send packets (In this case, interfaces that: supported, curr_speed and max_speed are 0).

Fix kytos/of_core#79

italovalcy commented 3 years ago

great work, guys! My only comment is: it should be interesting to allow the administrator to change the Interface config flags (e.g. to remove the flag OFPPC_NO_FWD) because sometimes the switch may report wrong values to cur/max/supported speeds. I'm not sure if manual changes to Interface config is already supported (e.g. via REST API) or not, so I would suggest taking this into consideration before accepting the PR.