I saw that you are using the name 'tp_src' and tp_dst for the MatchTCPSrc and MatchTCPDst, respectively, in v0x04/match_fields.py. I suggest you guys rename it to tcp_src and tcp_dst, which is more complaint with the naming schema of OF1.2+. The names tp_src/tp_dst were used on OF1.0, where they referred generically to the transport (tp) port.
We need to be careful when renaming this to avoid the tests and other napps break (even though I think there is no other napp using it).
Hi team,
I saw that you are using the name 'tp_src' and tp_dst for the MatchTCPSrc and MatchTCPDst, respectively, in v0x04/match_fields.py. I suggest you guys rename it to tcp_src and tcp_dst, which is more complaint with the naming schema of OF1.2+. The names tp_src/tp_dst were used on OF1.0, where they referred generically to the transport (tp) port.
We need to be careful when renaming this to avoid the tests and other napps break (even though I think there is no other napp using it).