search

kytta / shareon

📯 Lightweight, stylish, and ethical share buttons for popular social networks
https://shareon.js.org/
MIT License
465 stars 25 forks source link

Remove border on hovered <button> elements in the docs #16

Closed matthew-e-brown closed 4 years ago

matthew-e-brown commented 4 years ago

From the semantic awsm.css, hovered buttons get a one-pixel-wide black border when they're hovered. In the first example of the Usage section of the docs, this meant that hovering them would cause them to wiggle around slightly.

Given that this is a part of a separate library, not shareon itself, I figured that, while the wiggling around was almost certainly not intentional, neither was the black border. So, instead of keeping the border and removing the wiggling, this PR gets rid of both.

All this does is move the in-head <style> tag to underneath the awsm.css inclusion and add a copy of the same selector that caused the issue with a border: none. Given there aren't any buttons elsewhere on the page, this should be fine. 😄

kytta commented 4 years ago

Hi Matthew! Thank you for this fix, an amazing job! :tada: I'll merge it right now. Ignore the CI fail — it doesn't have to do affect the library :)