search

kytta / vue-tinybox

🌌 A slick, yet tiny lightbox gallery for Vue.js
http://os.kytta.dev/vue-tinybox/
MIT License
95 stars 7 forks source link

Add events: onNext, onPrev, onClose #28

Closed JoaquimLey closed 4 years ago

JoaquimLey commented 4 years ago

This will allow the user to add some biz-logic regarding component usage, e.g:

Hope this is a non-intrusive change as users who don't want to use these don't have to.

Fixes #27

JoaquimLey commented 4 years ago

Hey @NickKaramoff, Seems like this PR fails due to size limit by 14 bytes over the size-limit

ERROR: "test:size" exited with 1.
$ size-limit

  dist/tinybox.umd.js
  Package size limit has exceeded by 14 B
  Size limit: 3 KB
  Size:       3.01 KB with all dependencies, minified and gzipped

Please let me know if there's anything I can do to help mitigate this issue or you are willing to raise the limit.

kytta commented 4 years ago

And about the package size — I'll be ok with raising the bar a bit after we finalize the pull request. 0.01 KB is not a big deal :)

JoaquimLey commented 4 years ago

Hey @NickKaramoff please don't accept this PR just yet, for some reason my formating is messing up your own. I need to fix this before making way too many unwanted/unrelated changes.

In the meantime just LMK if the changes LGTY in terms of functionality, cheers.

EDIT: Looks like it should be running your own rules already 🤔, maybe it was just auto-cleanup, anyway I can remove all those formating changes if you want

kytta commented 4 years ago

Hey, @JoaquimLey I'll look into this PR at the end of the week. I'll make some tests; overall I think it's ready to be merged though.

Regarding the formatting: try installing ESLint and running eslint . --fix. This should fix most of the files. Should it not work correctly, no worries — I'll merge it anyway and fix the formatting myself; it's not that big of a deal for me :)