search

kyunghyuncho / NMT

1 stars 1 forks source link

Why another Bidirectional? #15

Open rizar opened 9 years ago

rizar commented 9 years ago

Guys, can you tell me why you copy-pasted Bidirectional from Blocks instead importing it? I guess there was a reason for it, but maybe it deserves an issue an Blocks to be created.

sebastien-j commented 9 years ago

When we were using the Bidirectional class from Blocks, the non-recurrent weight matrices were shared between the two RNNs.

rizar commented 9 years ago

Okay, that's a good reason.

In general I would like to ask you to create an issue in Blocks in such cases . It is very important for us to have a list of essential limitations of current code.

sebastien-j commented 9 years ago

Ok. I just opened an issue on this specific topic.