make websockets dependency optional

kyuupichan / aiorpcX

Generic async RPC implementation, including JSON-RPC

MIT License

27 stars 23 forks source link

make websockets dependency optional #20

Closed SomberNight closed 5 years ago

SomberNight commented 5 years ago

Electrum uses aiorpcx, but we don't plan to use the websockets functionality for now. For this reason, I would prefer making websockets an optional dependency.

coveralls commented 5 years ago

Coverage remained the same at 99.402% when pulling 662a660706c2d6f110762b51a1915d45ef3dc6ba on SomberNight:ws_extra into 10d62038c063774bfdf1001be3487424f55b7b14 on kyuupichan:master.

SomberNight commented 5 years ago

~~Oh wait, this is not enough; don't merge yet.~~

A further issue is that __init__.py imports the relevant module https://github.com/kyuupichan/aiorpcX/blob/10d62038c063774bfdf1001be3487424f55b7b14/aiorpcx/__init__.py#L8

SomberNight commented 5 years ago

Not really sure how to do this nicely tbh. The current change should work though.