search

kyuupichan / aiorpcX

Generic async RPC implementation, including JSON-RPC
MIT License
27 stars 23 forks source link

Fix SOCKSRandomAuth on Python 3.8+, bump Travis Ubuntu/Python versions #32

Closed JeremyRand closed 3 years ago

JeremyRand commented 4 years ago

SOCKSRandomAuth was broken on Python 3.8+ (both the username and password were returning None); this PR fixes it. Still works fine as far back as Python 3.6.0.

Feel free to cherry-pick just the bugfix commit if you don't want the Travis changes.

JeremyRand commented 4 years ago

Okay, this is ready for review now.

kyuupichan commented 4 years ago

The tests are failing on all the platforms?

JeremyRand commented 4 years ago

The tests are failing on all the platforms?

@kyuupichan I'm not sure why the tests are failing, but the fails seem to be unrelated to the bugfix commit. If you check the test results for 3.8 and higher for the SOCKS tests (compare before and after the bugfix commit), you'll see that it fixes one failure. Hence my suggestion that you may wish to cherry-pick the bugfix commit if you don't want the Travis changes.

mgorny commented 4 years ago

Ping. Maybe try restarting travis run, or it could be caused by Ubuntu upgrade. In any case, py3.8 support at this point in time is very important to us.

JeremyRand commented 4 years ago

Ping. Maybe try restarting travis run, or it could be caused by Ubuntu upgrade. In any case, py3.8 support at this point in time is very important to us.

@mgorny Do you want me to submit a PR with only the bugfix commit?

mgorny commented 4 years ago

Sure, if upstream's more willing to accept that ;-).

JeremyRand commented 3 years ago

@mgorny I've resubmitted as https://github.com/kyuupichan/aiorpcX/pull/34