search

kyuupichan / aiorpcX

Generic async RPC implementation, including JSON-RPC
MIT License
27 stars 23 forks source link

make CodeMessageError hashable #7

Closed SomberNight closed 6 years ago

SomberNight commented 6 years ago

see https://bugs.python.org/issue28603

It's very annoying and hard to debug when you lose exceptions completely as a task raised on the event loop and the code that was responsible for handling it also raised, due to the traceback.print_exc raising >.<

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.753% when pulling 4d1763d1595784cf14465ae129d260611c23f608 on SomberNight:hashable_exc into f7790920ee374c4e48833ac3e456aa82b371182f on kyuupichan:master.

kyuupichan commented 6 years ago

Could you add a comment in the function why it's needed, and add a test that such an exception is hashable?