kyzfrintin / Godot-Mixing-Desk

A complete audio solution for Godot 3.3.x, making procedural sound and adaptive/procedural music possible with a few nodes and a couple lines of code.
MIT License
636 stars 32 forks source link

Removed yield from _beat, reducing lag on Linux. #2

Closed ghost closed 5 years ago

ghost commented 5 years ago

Mixing Desk used yield in _beat to prevent processing a beat for multiple times. The approach introduces a lag that is quite noticeable on Linux.

This commit removed the yield call, and tracked triggered beats in a variable instead. This allows beats to be tracked more precisely, reducing the lag.

kyzfrintin commented 5 years ago

This is definitely a better way of keeping track of beats! And it's always good to make sure all platforms are supported. Will merge.