kyzn / cmpesweng2014group6

Automatically exported from code.google.com/p/cmpesweng2014group6
0 stars 1 forks source link

Code review request #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: develop-android

Purpose of code changes on this branch: Login, register, profile edit, forget 
password, add story, map interface and timeline functions

When reviewing my code changes, please focus on: Profile edit function, 
functionality of view and connection to db

Please review my code and write comments below.

Original issue reported on code.google.com by burcinca...@gmail.com on 2 Dec 2014 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by faziletc...@gmail.com on 2 Dec 2014 at 1:45

GoogleCodeExporter commented 9 years ago
I reviewed the code written by Burcin and here are my comments:

Generally the code is written really professionally, great work!

Variable names were meaningful, I was able to understand immediately.
Classes are functional and meaningful also, every class has a specific work and 
functionality.
I did not see any duplicate function or code, it seemed every function meets 
its purpose.
There could be more comments in the code, there are some comments at the 
necessary parts, but it can be improved.
Exceptions were handled well, I could not see any function returning null.
Resources (streams, database connections etc.) are released.
Inputs are validated for login, register, profile edit, forget password, add 
story, and for timeline.
Long story short, the code is understandable and meets its purpose and 
functionality.

Original comment by faziletc...@gmail.com on 2 Dec 2014 at 9:58