search

kyzn / cmpesweng2014group6

Automatically exported from code.google.com/p/cmpesweng2014group6
0 stars 1 forks source link

Code review request #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: develop-android

Purpose of code changes on this branch: Login, register, profile edit, forget 
password, add story, map interface and timeline functions

When reviewing my code changes, please focus on: Add story activity, 
functionality of view and connection to db

Please review my code and write comments below.

Original issue reported on code.google.com by burcinca...@gmail.com on 2 Dec 2014 at 9:31

GoogleCodeExporter commented 9 years ago

Original comment by kivancya...@gmail.com on 2 Dec 2014 at 3:39

GoogleCodeExporter commented 9 years ago 
I've reviewed AddStoryActivity.java, and here are my comments.

> First of all, great work! Looks like the code has met the business 
requirements.
> I've seen a method completely commented out, I was panicked but then I 
realized it was waiting for a fix. Hopefully we can handle this as soon as 
possible.
> One little thing, it would have been great to see more verbose & descriptive 
comments throughout the code.
> Exceptions were handled around line 160, and thank you very much for that!

Original comment by kivancya...@gmail.com on 2 Dec 2014 at 4:35