search

kyzn / cmpesweng2014group6

Automatically exported from code.google.com/p/cmpesweng2014group6
0 stars 1 forks source link

Code review request #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please review password operations implementation (ResetPassword.java, 
changePassword.jsp) and write your comments below.

Original issue reported on code.google.com by ugurkalk...@gmail.com on 2 Dec 2014 at 4:58

GoogleCodeExporter commented 9 years ago

Original comment by yunusemretekin1 on 3 Dec 2014 at 5:29

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by yunusemretekin1 on 3 Dec 2014 at 6:31

GoogleCodeExporter commented 9 years ago 
When the code is read, one can easily observe that the code is well-structured. 
In api part, Uğur handled every bad request possibilities. Api returns nice 
jsons to developer therefore, developer can easily write client side by using 
this api. He has found a nice way to handle resetPassword function. 
Furthermore, on the client side, uğur made a great job too. It seems that he 
placed every object in right div tags. A css coder would be very happy when he 
saw this well separated objects. Code does not seems confusing.

Original comment by yunusemretekin1 on 3 Dec 2014 at 6:55