search

kyzn / cmpesweng2014group6

Automatically exported from code.google.com/p/cmpesweng2014group6
0 stars 1 forks source link

Code review request #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please review timelineActivity in android

Original issue reported on code.google.com by yunusemretekin1 on 3 Dec 2014 at 4:29

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by faziletc...@gmail.com on 3 Dec 2014 at 6:05

GoogleCodeExporter commented 9 years ago 
I reviewed the code written by Yunus Emre, it was about timeline activity for 
Android application.

Generally the code is written really professionally.

Variable names were meaningful, I was able to understand immediately.
Classes are functional and meaningful also, every class has a specific work and 
functionality.
I did not see any duplicate function or code, it seemed every function meets 
its purpose.
There could be more comments in the code.
Resources (streams, database connections etc.) are released.
Long story short, the code is understandable and meets its purpose and 
functionality.

Original comment by faziletc...@gmail.com on 3 Dec 2014 at 6:12

GoogleCodeExporter commented 9 years ago

Original comment by faziletc...@gmail.com on 3 Dec 2014 at 6:12