Feature/testing circleci

kzampog / cilantro

A lean C++ library for working with point cloud data

MIT License

1.03k stars 208 forks source link

Feature/testing circleci #30

Closed gumeo closed 5 years ago

gumeo commented 5 years ago

I want to expose the option of doing hardware specific compilation in the build step.

I ran into an issue where I built the library remotely, on a machine with a larger instruction set than in my local machine, and I got a core dump illegal instruction when I tried to link on my machine.

I think it is better to make this more explicit.

kzampog commented 5 years ago

Thanks!

kzampog commented 5 years ago

Hi,

I made a few changes in 577d3fb27b17e2dc1a290ce7b3a5016afb121707 (added ENABLE_NATIVE_BUILD_OPTIMIZATIONS option and made ENABLE_NON_DETERMINISTIC_PARALLELISM independent of it). If you have any suggestions (e.g., have both of those OFF by default), please let me know!

Thanks again!