kzampog / cilantro

A lean C++ library for working with point cloud data
MIT License
1.01k stars 206 forks source link

GLEW not listed in cmake dependencies #35

Open norlesh opened 4 years ago

norlesh commented 4 years ago

Attempting to build under Visual Studio 2017 with both Eigen3 and Pangolin installed in my environment using Microsofts vcpkg source code package manager and while I was able to point CMake to there installed directories my build subsequently failed because GLEW was not found (specifically GL/glew.h) even though it is installed in the vcpkg system so I suppose for now I am going to need to update the project files by hand. I have posted a request to the vcpkg developers that they include support for Cilantro in the package manager which would mean a lot more cross platform use of your library under Visual Studio and am sure it would make there job a lot easier with the way the software works if that dependency was made explicit in the CMakeLists file.

kzampog commented 4 years ago

Hi,

Thank you for the vcpkg port attempt!

It seems that GLEW include dirs should automatically become part of Pangolin's include dirs (please see USER_INC CMake variable usage in https://github.com/stevenlovegrove/Pangolin/blob/master/src/CMakeLists.txt and https://github.com/stevenlovegrove/Pangolin/blob/master/src/PangolinConfig.cmake.in).

Does the error occur even on regular (e.g. non-vcpkg) CMake builds?