search

kzu / OctoHook

GitHub hooks made easy
Apache License 2.0
10 stars 2 forks source link

AutoLink support for labels with spaces #7

Open rjmurillo opened 9 years ago

rjmurillo commented 9 years ago

Some labels may have spaces, so including them causes the hook not to fire.

Today we use the +/- syntax to include a label (e.g. "+debt"), which cannot be used with labels containing spaces (e.g. "+technical debt"). Including the syntax causes the regular expression to fail (looking for EOL after label).

Suggest a mechanism to group the label text to allow for spaces (e.g. "+(technical debt)")

kzu commented 9 years ago

How about just optional quotes? On Mon, Sep 28, 2015 at 5:32 PM Richard Murillo notifications@github.com wrote:

Some labels may have spaces, so including them causes the hook not to fire.

Today we use the +/- syntax to include a label (e.g. "+debt"), which cannot be used with labels containing spaces (e.g. "+technical debt"). Including the syntax causes the regular expression to fail (looking for EOL after label).

Suggest a mechanism to group the label text to allow for spaces (e.g. "+(technical debt)")

— Reply to this email directly or view it on GitHub https://github.com/kzu/OctoHook/issues/7.

rjmurillo commented 9 years ago

@kzu Either way

kzu commented 9 years ago

Happy to merge a PR ;) On Mon, Sep 28, 2015 at 9:50 PM Richard Murillo notifications@github.com wrote:

@kzu https://github.com/kzu Either way

— Reply to this email directly or view it on GitHub https://github.com/kzu/OctoHook/issues/7#issuecomment-143912988.

rjmurillo commented 9 years ago

:+1: I'll work one up :smile:

kzu commented 9 years ago

:+1:! On Mon, Sep 28, 2015 at 10:01 PM Richard Murillo notifications@github.com wrote:

[image: :+1:] I'll work one up [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/kzu/OctoHook/issues/7#issuecomment-143914411.

rjmurillo commented 9 years ago

@kzu #9 has the PR. I've stepped through the code to verify it should behave as expected, but I could not verify since I don't have push access to the sandbox repo.