search

kzykhys / Ciconia

A New Markdown parser for PHP5.4
http://ciconia.kzykhys.com/
MIT License
355 stars 31 forks source link

Develop #41

Closed dereuromark closed 5 months ago

dereuromark commented 10 years ago

Adding support for GeShi highlighter.

It must be dev-master because of your stability setting. using "dev" there would work with geshi >= 1.0. That is why I used that one here. People can use dev as stability and then require >= 1.0 then if they want to.

I wonder, though, how both Pygments and Geshi could have settings passed with the current setup. We should probably allow customization. Either with additional options (array), or with events/hooks. Or add a DI approach for this, where you can pass in your "post parser". Options sounds easiest and could be: new ...Extension($options).

dereuromark commented 9 years ago

I could have sworn that the tests passed locally and fenced code blocks inside lists worked.