l-lin / angular-datatables

DataTables with Angular
https://l-lin.github.io/angular-datatables/
MIT License
1.58k stars 486 forks source link

Update to support angular 10 #1463

Closed Rene4100 closed 4 years ago

Rene4100 commented 4 years ago

I'm submitting a...


[ ] Bug report  
[ x ] Feature request
[ ] Documentation issue or request
[ ] Question

Current behavior

Currently, when migrating to angular 10 I get the following warnings npm WARN angular-datatables@9.0.2 requires a peer of @angular/common@^9.0.6 but none is installed. You must install peer dependencies yourself. npm WARN angular-datatables@9.0.2 requires a peer of @angular/compiler@^9.0.6 but none is installed. You must install peer dependencies yourself. npm WARN angular-datatables@9.0.2 requires a peer of @angular/core@^9.0.6 but none is installed. You must install peer dependencies yourself. npm WARN angular-datatables@9.0.2 requires a peer of @angular/platform-browser@^9.0.6 but none is installed. You must install peer dependencies yourself. npm WARN angular-datatables@9.0.2 requires a peer of @angular/platform-browser-dynamic@^9.0.6 but none is installed. You must install peer dependencies yourself.

Expected behavior

Instead of the warnings, I would really love support for angular 10. A guide can be found on angular's webpage


- node version: 12.16.1
- angular version: 10.0.5
- angular-cli version: 10.0.4
- jquery version: 3.5.0
- datatables version: 1.10.21
- angular-datatables version: 9.0.2
gongAll commented 4 years ago

So... Any news regarding this issue?

Rene4100 commented 4 years ago

@l-lin do you have time to consider updating angular-datatables to angular 10? Alternativly how can others like me be of any help?

vsangiovanni commented 4 years ago

I agree with that. We need it on Angular 10

l-lin commented 4 years ago

The angular-datatables v10.0.0 is out and should support Angular 10.