[Demo Project] changed html bookmarks to scrollToElement function

l-lin / angular-datatables

DataTables with Angular

https://l-lin.github.io/angular-datatables/

MIT License

1.57k stars 486 forks source link

[Demo Project] changed html bookmarks to scrollToElement function #1547

Closed theprogrammersingh closed 3 years ago

theprogrammersingh commented 3 years ago

Fixed console error in base-demo.component on the Docs website. Replaced the HTML bookmarks for Preview, HTML and TypeScript with a function call which will enable the smooth scroll effect.

shanmukhateja commented 3 years ago

Hey @simarpreetsinghkalra

Thank you for fixing this. I've been putting it off for sometime now.

Could you reword your Git commit to as follows: "fix(demo): error log when scrolling via Action buttons" ?

theprogrammersingh commented 3 years ago

Hey @shanmukhateja

Does the commit message looks good now?

shanmukhateja commented 3 years ago

LGTM