search

l-lin / angular-datatables

DataTables with Angular
https://l-lin.github.io/angular-datatables/
MIT License
1.57k stars 486 forks source link

security issue in dependencies #1604

Closed marcelschobert closed 2 years ago

marcelschobert commented 2 years ago

Hi I have added the newest angular-datatables version (12.0.0) to my project and since 1 week or so there is an known issue with ansi-regex which is included in @angular/cli. That would not be an problem because it normaly is only used in the devDependencies. But angular-datatables has the @angular/cli package in its dependencies and because of that even "npm audit --production" returns an issue.

Is the @angular/cli package really needed in the dependencies or can it be moved to the devDependencies?

shanmukhateja commented 2 years ago

Hi,

I think it would be safe to move @angular/cli to devDependencies.

PR is always appreciated.

marcelschobert commented 2 years ago

Hi @shanmukhateja , do you know when the next release will be? It would be nice to have the fixed package.json in my project.

shanmukhateja commented 2 years ago

Hi @marcelschobert new version v12.0.1 is released to NPM. Please let me know if the issue is fixed.

shanmukhateja commented 2 years ago

I'm closing this issue. Feel free to re-open this if it didn't work @marcelschobert

marcelschobert commented 2 years ago

Sorry, I forgot to answer you. It is working great, thanks for the fast release.