Closed misraved closed 1 month ago
Hi @misraved,
Thank you very much for your review and support!
Can you please have a look into #4? It should address all your suggestions :)
Regarding:
Could you please explain the difference between DETECTIFY_API_SECRET and DETECTIFY_API_TOKEN_V3 config arguments?
This was actually a typo on the README.md
that was fixed on #1 on detectify.spc
but not in the README. The variable name for DETECTIFY_API_TOKEN_V3
should be tokenv3
instead. It is also fixed as part of the PR ☝️.
Thank you @l-teles for the new plugin. The basic structure and results look good so far. While using the plugin, we did come up with a few suggestions based on our best practices:
README
anddocs/index.md
files:token
andsecret
, could you please use dummy values that are close to the actual format of the config arguments?DETECTIFY_API_SECRET
andDETECTIFY_API_TOKEN_V3
config arguments?Makefile
as per https://github.com/turbot/steampipe-plugin-aws/blob/main/Makefile? This will also help local developers to build the plugin using thenetgo
package.Overall the plugin looks great, the tables and the example queries are very compact.
Great work 🎉 !!