l0b0 / mian

Mine analysis - Graph blocks to height in a Minecraft save game
https://github.com/l0b0/mian/wiki
GNU General Public License v3.0
14 stars 4 forks source link

Save path #15

Closed Ape closed 13 years ago

Ape commented 13 years ago

The --save option is great, but you should be allowed to set the save path.

Mock up: mian.py --save /srv/http/minecraft/ores.png /srv/minecraft/world

Fenixin commented 13 years ago

Also, a resolution for the image would be great!

dalbothek commented 13 years ago

Also being able to save a png without a $DISPLAY would be great!

Traceback (most recent call last):
File "/usr/local/bin/mian", line 9, in <module>
load_entry_point('mian==0.9.2', 'console_scripts', 'mian')()
File "/usr/local/lib/python2.6/dist-packages/mian-0.9.2-py2.6.egg/mian/mian.py", line 408, in main
mian(world_dir, block_type_hexes, nether, log, interactive)
File "/usr/local/lib/python2.6/dist-packages/mian-0.9.2-py2.6.egg/mian/mian.py", line 258, in mian
plot(total_counts, block_type_hexes, title, log, interactive)
File "/usr/local/lib/python2.6/dist-packages/mian-0.9.2-py2.6.egg/mian/mian.py", line 176, in plot
fig = plt.figure()
File "/usr/lib/pymodules/python2.6/matplotlib/pyplot.py", line 254, in figure
**kwargs)
File "/usr/lib/pymodules/python2.6/matplotlib/backends/backend_tkagg.py", line 90, in new_figure_manager
window = Tk.Tk()
File "/usr/lib/python2.6/lib-tk/Tkinter.py", line 1646, in __init__
self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
_tkinter.TclError: no display name and no $DISPLAY environment variable
l0b0 commented 13 years ago

Excellent suggestions all, but at this point I'm more of a lurker here than a developer, or even user. If anyone has the time to develop this, I'd be happy to pull and create a new release (or if someone wants to join in the release work).

Fenixin commented 13 years ago

I'll be glad to add these features! What means to join to the release work?

Fenixin commented 13 years ago

This feature request is implemented. The option to do this is "--output" or "-o". I'm going to close the issue, feel free to reopen it or open a new one if you think there is something missing.