search

l0b0 / mian

Mine analysis - Graph blocks to height in a Minecraft save game
https://github.com/l0b0/mian/wiki
GNU General Public License v3.0
14 stars 4 forks source link

Corrected the shebang to be python2 #16

Open Ape opened 13 years ago

Ape commented 13 years ago

On many systems /usr/bin/env python points to python3. You should explicitely tell it to use python2.

l0b0 commented 13 years ago

Thanks! Could you perhaps change it to 2.6, since that's effectively the version used for all the development?

Ape commented 13 years ago

For example my system doesn't have 2.6 installed. I am able to install it if I need, but since mian works fine with 2.7 there is no need for that. So we should leave it just python2.

pepijndevos commented 13 years ago

There is a matplotlib branch fro py3k, maybe we could support that? I'll create an issue for it if it is something we want.

https://github.com/matplotlib/matplotlib-py3

l0b0 commented 13 years ago

@Ape: OK, that's cool. Anyway, setup.py specifies that it should use 2.6. Pulling...

@pepijndevos: I'm wondering how stable that is - README.txt still mentions only 2.5 and 2.6, which makes it seem like it's not very far yet. But you're welcome to experiment with it, of course.

l0b0 commented 13 years ago

@Ape: Eh, looks like python2 is not present on Ubuntu by default (only python and python2.6 on 10.10) - Could you look for a more portable shebang?

pepijndevos commented 13 years ago

IMO, setting python to point to python3 is a bad move form the distros. A better long term solution for us would be to support py3k.

quote form IRC:

drnlm fliebel: maptlotlib has a python3 branch on github - there are still issues with the test suite, and not all the backends work, but it's getting there.

Ape commented 13 years ago

It's true that the ultimate solution would be to go with Python 3. I don't know how nicely matplotlib works with it, but who said we can't use any other libraries. I'd actually prefer a simple drawing library that could just produce an image file.

pepijndevos commented 13 years ago

Suggestions?

l0b0 commented 13 years ago

A possible solution. Not trivial, not perfect, but it could do the trick. Does anyone have the time to implement and test?

Fenixin commented 13 years ago

More suggestions? The last l0b0 suggestions seems too hacky... don't know what to do. Maybe we can leave it as it is and open a wiki page with a FAQ or known issues.

What do you think?

macfreek commented 13 years ago

I think the best way to solve this is to make the code both Python2 and Python3 compatible, but admittedly, that takes a bit of work.