l10nelw / winger

Window Manager: A Firefox web extension for switching windows, moving tabs between windows, and more
https://addons.mozilla.org/firefox/addon/winger/
GNU General Public License v3.0
48 stars 7 forks source link

Incompatible with other addons that are using titlePreface #31

Closed Lej77 closed 4 months ago

Lej77 commented 8 months ago

Even if a window name is never specified this addon will still update the titlePreface, clearing any titlePreface specified by other addons. It would be nice if this behavior could be disabled so that it is possible to use other addons for the title preface. I am using Tab Count in Window Title, but there are a lot of other addons that also make use of the titlePreface. For example Sidebery allows setting it when its sidebar is visible to control CSS inside userChrome.css.

While an "enable window title" checkbox on the settings page (that is checked by default) would be enough to fix this I think you should also consider making the sessions permission optional. I did this for my Tab Count in Window Title addon by making the permission request the first time a user tried to name a window and that seems quite intuitive to me. Though thinking about this some more, it is possible that a user would want to name a window without actually changing the window title. So having both a checkbox and an optional permission could make sense.

frasty commented 8 months ago

Probably related to this issue, I use window titler and winger actually clears the window titles I previously specified with window titler. It would be nice if winger could inherit the title from window titler and other addons that make use of titlePreface.

l10nelw commented 8 months ago

Thank you for this. I have been planning to make window naming optional for quite some time to accommodate other window titlers. I'll make this a priority.

Lej77 commented 4 months ago

This issue seems to be fixed in version 2.5.0 of the extension, see issue #40.

l10nelw commented 4 months ago

https://github.com/l10nelw/winger/wiki/Using-Winger-with-another-window-naming-extension