search

l10nelw / winger

Window Manager: A Firefox web extension for switching windows, moving tabs between windows, and more
https://addons.mozilla.org/firefox/addon/winger/
GNU General Public License v3.0
50 stars 6 forks source link

[BUG] Winger forgets "stash home" folder on Firefox restart and creates a new empty one. #54

Open mkalinski opened 1 month ago

mkalinski commented 1 month ago

To reproduce:

  1. Set up winger to use as "stash home" some named folder within the bookmarks toolbar root. Winger will create this folder.
  2. Move this folder to a different spot on the toolbar (from last position to first, or wherever).
  3. Winger correctly uses this folder as its stash home.
  4. Restart Firefox.
  5. On initialization, Winger creates a new, identically named folder in the original spot, and refuses to use the folder it was using in the previous Firefox session.

In practice, this means that the "stash home" folder can never be moved to a different position than where Winger created it. This is pretty problematic for the bookmarks toolbar.

l10nelw commented 1 month ago

I think I know what's going on.

In root folders such as Bookmarks Toolbar, Winger ignores everything before the last separator, if at least one exists (Winger automatically adds a separator if necessary). It's useful if you use a root folder as the stash home, since you'll likely have existing items in it that you want to be statically positioned and not eventually pushed out of view by new stashes.

This feature is currently missing from the documentation, so I need to rectify that. Also this feature isn't very useful if you're not using a root folder as the stash home, so yes I'll regard it as a bug and fix it.

For now, just place your stash home folder after the separator and it should work. Let me know if this isn't the case.

mkalinski commented 1 month ago

That's actually a pretty useful functionality that would make me organize the stash home differently… had I known it's there. :stuck_out_tongue: