search

l1dge / techswap

Repo for the techswap project
2 stars 0 forks source link

Removed redundant code and templates #47

Closed l1dge closed 3 years ago

l1dge commented 3 years ago

Hi Bob, One down 12 more to go ;-)

Issue 45 - Removed redundant code and templates

Cheers Lee

l1dge commented 3 years ago

SwapMixin wasn't working, kept creating a new wishlist everytime you logged in. Fixed now and your wishlist should be persistent across sessions now.

bbelderbos commented 3 years ago

SwapMixin wasn't working, kept creating a new wishlist everytime you logged in. Fixed now and your wishlist should be persistent across sessions now.

Ouch which line caused the bug? https://github.com/l1dge/techswap/pull/47/commits/84023962907ce68e7c393fa4f040b81879ada129

Would be nice to write a test for this ;)

l1dge commented 3 years ago

SwapMixin wasn't working, kept creating a new wishlist everytime you logged in. Fixed now and your wishlist should be persistent across sessions now.

Ouch which line caused the bug? 8402396

Would be nice to write a test for this ;)

It was the line that sets the list_id, it was basically getting it from the session rather than from the WishList table so my items kept disappearing everytime I logged out lol and yes we'll add a test for this. ;-)

bbelderbos commented 3 years ago

SwapMixin wasn't working, kept creating a new wishlist everytime you logged in. Fixed now and your wishlist should be persistent across sessions now.

Ouch which line caused the bug? 8402396 Would be nice to write a test for this ;)

It was the line that sets the list_id, it was basically getting it from the session rather than from the WishList table so my items kept disappearing everytime I logged out lol and yes we'll add a test for this. ;-)

Great catch!