l1f7 / surface

:construction: Building blocks & guidelines for front-end at Lift (deprecated: unmaintained)
2 stars 1 forks source link

Linting tasks exit dirty when linters return issues... #8

Closed hyshka closed 7 years ago

hyshka commented 7 years ago

Would be nice to see then exit cleanly if possible, even if errors are returned.

Ex.

root@badc8ef7b766:/app# nlj
npm info it worked if it ends with ok
npm info using npm@3.10.7
npm info using node@v6.9.4
npm info lifecycle surface@1.0.0~prelint:scripts: surface@1.0.0
npm info lifecycle surface@1.0.0~lint:scripts: surface@1.0.0

> surface@1.0.0 lint:scripts /app
> npm run linter:eslint -s

/app/raw/js/App.js
  18:1  error  All 'var' declarations must be at the top of the function scope  vars-on-top
  18:1  error  Unexpected var, use let or const instead                         no-var

✖ 2 problems (2 errors, 0 warnings)

npm info lifecycle surface@1.0.0~lint:scripts: Failed to exec lint:scripts script
npm ERR! Linux 4.10.1-1-userns
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "lint:scripts"
npm ERR! node v6.9.4
npm ERR! npm  v3.10.7
npm ERR! code ELIFECYCLE
npm ERR! surface@1.0.0 lint:scripts: `npm run linter:eslint -s`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the surface@1.0.0 lint:scripts script 'npm run linter:eslint -s'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the surface package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run linter:eslint -s
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs surface
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls surface
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /app/npm-debug.log
hyshka commented 7 years ago

Need to add -s flag...unfortunately.