l1npengtul / nokhwa

Cross Platform Rust Library for Powerful Webcam/Camera Capture
Apache License 2.0
482 stars 111 forks source link

V4L performance divide by two when starting stream #128

Closed OlivierLDff closed 1 year ago

OlivierLDff commented 1 year ago

PR https://github.com/l1npengtul/nokhwa/pull/121 introduce a performance regression. When calling stream.start, frame rate is divided by 2. I have no idea why, I'm currently investigating.

OlivierLDff commented 1 year ago

I found the catch:

My suggestion is that nokhwa shouldn't call stream.start, or put it behing a feature flag. So by default performance are normal. On raspberry PI performance can be downgraded in order not to crash.