l1npengtul / nokhwa

Cross Platform Rust Library for Powerful Webcam/Camera Capture
Apache License 2.0
482 stars 111 forks source link

Bump v4l to 0.14 and v4l2-sys-mit to 0.3 #156

Closed alufers closed 5 months ago

alufers commented 8 months ago

0.13 and 0.3 were pretty old and caused bindgen errors on Linux (Arch Linux updated to latest everything :) ).

This was the error:

thread 'main' panicked at /home/alufers/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bindgen-0.56.0/src/ir/context.rs:846:9:
  "v4l2_pix_format_union_(anonymous_at_/usr/include/linux/videodev2_h_500_2)" is not a valid Ident

After bumping to 0.14 and 0.3 versions, it goes away because bindgen has been updated in v4l2-sys-mit 0.14.

axelkar commented 5 months ago

Y'all didn't even test it. Neither upstream nor your pull compile.

This isn't needed when using the branch 0.10: https://github.com/l1npengtul/nokhwa/commit/f1405412e5e45f04339670d2f04aa88ccadb486b