l1xnan / obsidian-better-export-pdf

Obsidian PDF export enhancement plugin
MIT License
242 stars 13 forks source link

Task-plugin #177

Open merlinuwe opened 2 months ago

merlinuwe commented 2 months ago

(I thought, there already was a threat with this issue, but I can't find it.)

When I use a new TestVault and only have tasks plugin and yours installed, I get this from your plugin:

image

And I get this from Obsidians native pdf export.

image

muell-export-pdf-task-obsidian-native-pdf.pdf

muell-export-pdf-task-obsidian-better-export-pdf.pdf

muell-export-pdf-task.md

Was confirmed here:

https://forum.obsidian.md/t/pdf-export-of-tasks-not-all-tasks-are-in-the-exported-pdf-file/80375/2

I think, I better test with an isolated vault.

l1xnan commented 2 months ago

The problem is still caused by the inability to obtain the completion time of tasks rendering. I have not yet found a good way to obtain the completion time of third-party plugin rendering. I have added a detection method, although it is not perfect, it only mitigates the problem. I have tested it with 2000 tasks and it worked properly.

better-export-pdf.zip

merlinuwe commented 2 months ago

The problem is still caused by the inability to obtain the completion time of tasks rendering. I have not yet found a good way to obtain the completion time of third-party plugin rendering. I have added a detection method, although it is not perfect, it only mitigates the problem. I have tested it with 2000 tasks and it worked properly.

better-export-pdf.zip

I made a new testVault with minimal plugins, changed the files to those you provided in the post above and it looks well:

image


But with my productive Vault and the same changes, I get this:

image

(No console output.)

(A refresh makes no difference.)

image


I guess, in my productive fault something is slowing down the process.

l1xnan commented 2 months ago

Noting that the latter half of the task appears while the first half is blank, it may not be caused by the issue of slow rendering. If you see all the tasks in the preview interface, at this point, the rendering is already complete. The next step is to call the interface to export the PDF, rendering will no longer affect the final result. The problem should be in the stage of invoking the underlying interface to print the PDF. It may be related to #162 , but I have never found the reason.

l1xnan commented 2 months ago

Can you try adjusting the page size and margins to see if there are different results?

merlinuwe commented 2 months ago

Good idea.

Test with my productive vault:

Correct:

15_35_A0_muell-export-pdf-task.pdf

15_38_A1_muell-export-pdf-task.pdf

Not correct:

15_39_A2_muell-export-pdf-task.pdf

15_25_A3_muell-export-pdf-task.pdf

15_41_A4_muell-export-pdf-task.pdf

Your preview is always ok. One should believe, as long as there is no page break, the export of the pdf file works correct... but then comes A5, which works again.

15_43_A5_muell-export-pdf-task.pdf

A6 has 2 empty sites:

15_43_A6_muell-export-pdf-task.pdf


Test with my testVault:

A0, A1 works and even A2, A3, A4, A5 and A6 which have page breaks.

15_43_A0_muell-export-pdf-task.pdf 15_49_A1_muell-export-pdf-task.pdf 15_49_A2_muell-export-pdf-task.pdf 15_50_A3_muell-export-pdf-task.pdf 15_50_A4_muell-export-pdf-task.pdf 15_50_A5_muell-export-pdf-task.pdf 15_53_A6_muell-export-pdf-task.pdf

In my TestVault, every output works. There must be something wrong with my productive vault.

BTW: In your data.json, there is a typo:

pageSise -> pageSize

data.json

l1xnan commented 2 months ago

Thank you very much for your thorough testing. You could try disabling all plugins in the productive vault and only keeping a few essential ones enabled, then systematically check which plugin is causing the issue.