l2- / template-plugin

BSD 2-Clause "Simplified" License
7 stars 8 forks source link

XP Drop colour not changing while using godsword and piety #102

Closed spookychini closed 3 months ago

spookychini commented 4 months ago

Mine is usually set to red when using a melee weapon and piety. Works for other weapons but not godswords.

an-aprilia commented 4 months ago

I can confirm this does not work for godswords. Bug can also be reproduced with the Abyssal Bludgeon.

Reproduction Steps:

  1. Equip Abyssal Bludgeon or Bandos Godsword
  2. Turn on Piety
  3. Attack an NPC

Expected: XP drop is colored based on plugin settings for "XP drop color melee". Observed: XP drop is colored based on default drop color, "XP drop color"

image

Video here (currently uploading): https://youtu.be/0GxfhOrYEEA

QGoh commented 4 months ago

Same issue also exists with Keris Partisan of Breaching.

l2- commented 4 months ago

Hopefully fixed with the merging of https://github.com/runelite/plugin-hub/pull/5733

DuayneDibbley commented 4 months ago

Just tested again and doesn't seem to be fixed. Tested with SGS and BGS

hawkins commented 1 month ago

I am also still seeing this bug with the Keris Partisan of Breaching