search

l2- / template-plugin

BSD 2-Clause "Simplified" License
7 stars 8 forks source link

customizable xp drop not attached to target. #27

Closed lvl30ditto closed 2 years ago

lvl30ditto commented 2 years ago

right now its just floating around some where. yesterday iit was working fine. now its not working. its floating some where of screen. maybe the new update broke it

NarZook commented 2 years ago

Yeah. It's definitely not working. Today's update seems to have broken something.

Tylanderr commented 2 years ago

This issue seems to only be happening with the attach to target / attach to player options. With those turned off, xp drops appear in the standard rendered drop area as expected.

The issue specifically seems to be with the x value after getting the Point using getCanvasTextLocation. I'm unsure where the text used to show up when x=0 (my assumption would be far left side of the game screen), but now when x is set to 0, it renders on the right of the playable screen (see screenshot). Since we're getting a positive x value from the Point, it's pushing it far off to the right, and into the minimap area. Setting x = -x, puts the text more towards the player center screen, but the behavior isn't like prior to todays update. Hopefully any of this info is useful. image

lvl30ditto commented 2 years ago

gonna wait for the update :)

l2- commented 2 years ago

Hi, seems from a bit of testing that Runelite made it so the overlay now takes the moveable overlay position into account even for overlays that are of the dynamic type (or maybe its because I change the type to dynamic at runtime which might not be what the Runelite people expect someone to do). In any case a little workaround until this is fixed: turn off attack to player and turn off attach to target. Hold alt and drag the overlay to the top left corner of the viewport. Make sure it does not snap to the group in the top left, or the position changes when another overlay in that group is rendered in front of this one. Now turn on either of the attach options again and the xp drops should be in the correct place again.

lvl30ditto commented 2 years ago

t

Hi, seems from a bit of testing that Runelite made it so the overlay now takes the moveable overlay position into account even for overlays that are of the dynamic type (or maybe its because I change the type to dynamic at runtime which might not be what the Runelite people expect someone to do). In any case a little workaround until this is fixed: turn off attack to player and turn off attach to target. Hold alt and drag the overlay to the top left corner of the viewport. Make sure it does not snap to the group in the top left, or the position changes when another overlay in that group is rendered in front of this one. Now turn on either of the attach options again and the xp drops should be in the correct place again.

this doesnt really work for me. i just dragged the box towards the target that kinda works. i am asuming it will be updated later this week? or weekend? :P i really enjoy the plugin for pking. :D

l2- commented 2 years ago

https://github.com/runelite/plugin-hub/pull/2705 This should fix it.

lvl30ditto commented 2 years ago

when will runelite update the version from 1.5 to 1.5.1

ruchir90 commented 2 years ago

when will runelite update the version from 1.5 to 1.5.1

dude relax it will come when its ready be grateful for the free service

NarZook commented 2 years ago

when will runelite update the version from 1.5 to 1.5.1

dude relax it will come when its ready be grateful for the free service

Dude just asked a question..

l2- commented 2 years ago

when will runelite update the version from 1.5 to 1.5.1

There's a couple of people who can merge and one of those has to merge the pull request. All of them are volunteers so it's hard to say when they have time to do it.

That said 1.5.1 is now merged and should be live, hope it solves the issue.

lvl30ditto commented 2 years ago

when will runelite update the version from 1.5 to 1.5.1

dude relax it will come when its ready be grateful for the free service

Dude just asked a question..

Dude relax go outside and touch grass instead of arguing to a convo you weren't even a part of.

can you not start shit? ur comment didnt add any value. i was just hyped for the plugin i just recently discovered. some one else defended me. and now ur trying to start drama. you should leave this. go outside and touch grass.

lvl30ditto commented 2 years ago

Thank you for everything l2- gonna close the ticket since everything is resolved :D