search

l2- / template-plugin

BSD 2-Clause "Simplified" License
7 stars 8 forks source link

Overlay going above xp globe overlay #63

Closed Jbleezy closed 10 months ago

Jbleezy commented 1 year ago

When both the xp globe overlay and the overlay from this plugin are locked to the same area, the overlay from this plugin is now going on top where before it didn't

l2- commented 1 year ago

It's because i set the priority explicitly now. There's a ton overlays that the plugin needs to account for and i don't think theres a perfect priority for the overlay in this plugin that will fix all current and future ordering issues. Maybe i should change the layer back to above widgets to avoid most of the collision cases. Although under widgets is more logical I didn't see a real change in behavior so why did you pull request it to be under widgets?

Rakqoi commented 1 year ago

This is a problem for me as well. I like to have both xp drops and xp globes in the corner beside my minimap, but now the xp drops appear above the globes and it pushes globes way down on the screen. It's a huge shame, since I really love this plugin, but I can't use it like this unfortunately. I hope you consider reverting the change, or change the ordering so it is forced to appear below xp globes. 2023-03-01_21-03-18

Jbleezy commented 1 year ago

I think the xp globe overlay should definitely be accounted for though since these two overlays are very closely related. If that is possible while keeping under widgets that would be amazing.

l2- commented 1 year ago

Honestly I don't think I can do anything but set the xp globes overlay priority explicitly (because right now it's set to none which means sorting the overlays is done in first added first shown matter which is very inconsistent) and i really doubt runelite would bother or even want to accept that...

l2- commented 10 months ago

Should be possible to configure once https://github.com/runelite/plugin-hub/pull/4950 is merged