search

l20n / spec

Specification and design documents for L20n
http://l20n.github.com/spec/
10 stars 6 forks source link

Allow at most one default in a member list #10

Closed spagy closed 7 years ago

stasm commented 7 years ago

Thanks for the PR @spagy! I agree that this is desirable but I'd also like to hear what @Pike and @zbraniecki think about this.

Pike commented 7 years ago

stas and I also talked about requiring the default member for variants.

This might be the PR to add that to, if we think we should do that.

spagy commented 7 years ago

I've added default-list, which is used to simplify the definitions of trait-list and variant-list but I don't really like the name. To me it sounds like default-list is the definition of a "default list" rather than a list involving a default member. If anyone has a suggestion for a better name I'd be happy to change it.

spagy commented 7 years ago

@Pike, it looks like that's what @stasm was talking about in his previous comment. If that is what you're talking about then I've added that. Otherwise, would you be able to explain further?

spagy commented 7 years ago

This commit log is getting slightly messy. Once everything is sorted out I'd be happy to rebase.

stasm commented 7 years ago

@zbraniecki How hard would it be to enforce this in the current parsers implementations?

GlenDC commented 7 years ago

Are the EBNF grammar changes in this PR already approved?

stasm commented 7 years ago

We moved the development of the core of l20n into a new project and a new repository. I re-filed this issue there and submitted a PR based on this one: https://github.com/projectfluent/syntax/pull/13