search

l2beat / earl

☕ Ergonomic, modern and type-safe assertion library for TypeScript
https://earl.fun/
MIT License
256 stars 19 forks source link

`node:test` support #308

Closed alcuadrado closed 3 weeks ago

alcuadrado commented 1 month ago

Hey @sz-piotr,

I continued your work on #305 in this PR.

Your previous TODO:

What does the last todo item mean? I'm willing to fix it if you explain it.

Also, can I add info about node:test to the readme and the docs?

I really really think this library + node:test are a great combo

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 9680303ffa9090c5558a93ef49fded6e2b667507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------- | ----- | | earl | Minor | | website | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
earl-docs ✅ Ready (Inspect) Visit Preview May 18, 2024 0:01am
alcuadrado commented 1 month ago

I understand what the last TODO item means now. I believe it may come from not using project references and tsc getting somewhat lost.

From a separate npm project things work as expected.

alcuadrado commented 1 month ago

I understand what the last TODO item means now. I believe it may come from not using project references and tsc getting somewhat lost.

I can try to fix this, but would like to validate it with you first, as it would touch most tsconfig.json files.

alcuadrado commented 1 month ago

I understand what the last TODO item means now. I believe it may come from not using project references and tsc getting somewhat lost.

I can try to fix this, but would like to validate it with you first, as it would touch most tsconfig.json files.

No, it's not that. The problem is that the example-plugin is CJS-only, so it imports the CJS version of earl, while the example imports the ESM one.

sz-piotr commented 1 month ago

@alcuadrado Great work. Sorry I couldn't look at this earlier, I was really busy with conferences. I'll try to review this week and hopefully get this merged and released.

alcuadrado commented 3 weeks ago

LFG! 🚀

I'll send an PR updating the readme and docs to reflect this.

Small note @mateuszradomski, you forgot to tag the release here on GH.