search

l3kn / org-fc

Spaced Repetition System for Emacs org-mode
https://www.leonrische.me/fc/index.html
GNU General Public License v3.0
258 stars 31 forks source link

Feat/daily new limit #95

Open cashpw opened 1 year ago

cashpw commented 1 year ago

This is built on top of #82. Related: #80.

cashpw commented 1 year ago

On second thought, this could use some tests. I'll be away for the next two weeks but could add then when I get back.

cashpw commented 1 year ago

How set are you on limiting the number of new cards per day instead of per review session?

I prefer daily based on my history with flashcard applications. However, this doesn't need to be the case for everyone. I've added org-fc-review-new-limit-schedule which allows users to set either 'day or 'session.

l3kn commented 1 year ago

Looks good, I like how configurable this is now.

One caveat to keep in mind is that if Emacs is restarted, the daily limit is lost. That's fine for me as long as we add this info to the docs, persistence for the daily count / reset day can always be added in later.

Regarding testing it should be sufficient to mock different values for the daily count / reset day and count the new cards from a selection of (unshuffled) cards.

cashpw commented 1 year ago

One caveat to keep in mind is that if Emacs is restarted, the daily limit is lost. That's fine for me as long as we add this info to the docs, ...

Good point. I've updated the doc strings.

persistence for the daily count / reset day can always be added in later.

I've created #98 to track this work.

cashpw commented 1 year ago

Checking in. Are there any changes you'd like to see before this is merged?

cashpw commented 1 year ago

Checking in -- is there anything you'd like to see changed in this pull request?