search

l3lackShark / gosumemory

Cross-Platform memory reader for osu!
GNU General Public License v3.0
692 stars 63 forks source link

Keyoverlay showing wrong values on Linux #167

Open hwsmm opened 1 year ago

hwsmm commented 1 year ago

Hi, I've been writing memory reader of mine in another language, and I just found out that https://github.com/l3lackShark/gosumemory/blob/f80a655b5e2088da03f91e64d552b9e13540ceea/memory/functions.go#L51-L55 applies the same to these lines. (0xC instead of 0x8) https://github.com/l3lackShark/gosumemory/blob/f80a655b5e2088da03f91e64d552b9e13540ceea/memory/functions.go#L433-L442

I'd write a PR if I were good enough at Go, but unfortunately I couldn't come up with a good solution, so I am just writing an issue.

C0D3-M4513R commented 1 year ago

So you are saying, that K1Pressed should be the same as K2Pressed? And K1Count should be the same as K2Count=? seems broken...

KotRikD commented 1 year ago

It's not the same thing. It just pointers to start of array with values. LeaderStart is needed to calculate current value pointer in array (NOT START OF ARRAY)