l3lackShark / gosumemory

Cross-Platform memory reader for osu!
GNU General Public License v3.0
690 stars 64 forks source link

[Feature] Move Module Width/Height #62

Open C0D3-M4513R opened 3 years ago

C0D3-M4513R commented 3 years ago

So I noticed, that for every Module, there is a Width and Hight. Those combos are Static. One Module cannot have multiple Width's and Height's (afaik). So how about removing the following properties:

overlayURL = http://localhost:24050/Simplistic
overlayWidth = 650
overlayHeight = 150

and replacing them with the following:

overlayName = Simplistic

Everything before and after would still stay the same of course. One could still reconstruct the needed URL, because we have serverip as a property. The reconstruction should just look similar to this: "http://" + serverip + "/" + overlayName (Please use format Strings in actual code!).

One could then add a config.ini file to each module, where it's height and width are stored. Something along the lines of this:

Width = 650
Height = 150
l3lackShark commented 3 years ago

Not sure about the serverip thing as it supports golang formatting (stuff like :24050) static's index.html will see a lot of changes soon so the other parts of this proposal might come as a part of that change.