l3montree-dev / devguard

DevGuard Backend - Manage your CVEs seamlessly, Integrate your Vulnerability Scanners, Security Framework Documentation made easy, Compliance to security Frameworks - OWASP Incubating Project
https://flawfix.dev
Other
37 stars 4 forks source link

Updating the security requirements should recalculate the rawRiskAssessment #100

Closed Refoo0 closed 2 months ago

timbastin commented 2 months ago

It looks great! We might want to show to the user the "old" risk assessment of a flaw and the new one. Can you add that functionality?

timbastin commented 2 months ago
  1. Add arbitraryJsonData map[string]anyand ArbitraryJsonData stringjson:"arbitraryJsonData" gorm:"type:text;"` tomodels.FlawEvent`
  2. Copy the methods GetArbitraryJsonData and SetArbitraryJsonData
  3. Only mutate the Flaw struct inside models.FlawEvent@Apply method
  4. Save the "old" and the "new" risk values from the flaw inside the arbitraty json data field
  5. Try todo everything inside the same transaction (Updating the requirements, updating the flaws, creating the events)

Hint:

func NewRawRiskAssessmentUpdatedEvent(flawID string, userID string, justification string, oldRiskAssessment float64, newRiskAssessment float64) FlawEvent
gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [12246468](https://dashboard.gitguardian.com/workspace/227261/incidents/12246468?occurrence=151346241) | Triggered | RSA Private Key | d2bcd6ca35878567f302df022c804aeb43cf327b | flawfix.2024-06-25.private-key.pem | [View secret](https://github.com/l3montree-dev/flawfix/commit/d2bcd6ca35878567f302df022c804aeb43cf327b#diff-badaf7335d26bd950d5e170bb5b0da245fb7c65bb5211733e230a0cae9c8e0e4R1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/private_key_rsa#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.