Open Flowtter opened 1 year ago
You mean eslint? FWIW I've added editorconfig-checker to the development dependencies in #128, so if we add a GitHub action (and we should!) let's not forget to check against all linters.
Also I think pre-commits hooks would be just as important as a GitHub action. :)
Some files do not respect the current linter configuration (eslint). https://github.com/l3mpire/lemverse/blob/19a80c88c939892a865bc2f82d0182ec944c8e66/core/client/scenes/scene-editor.js#L114-L119
The expected behavior would be:
I'm thinking about making a PR with all the fixes, but that might create a lot of merge conflicts in the pending pull requests.
Would you allow us to lint correctly the files we're editing in our pull request, or would you rather do one single pull request/commit to fix all the project?
Adding a GitHub action to check the linting of the code would also probably be a good idea.