search

l3mpire / lemverse

The first-ever coworking metaverse
https://app.lemverse.com
GNU Affero General Public License v3.0
149 stars 40 forks source link

Add CI and pre-commit #159

Closed Flowtter closed 1 year ago

Flowtter commented 1 year ago

This PR reformat all the code and add pre-commit checks and GitHub actions tests. image image

You'll also need to merge it without a rebase to keep the hash of the commit for the git-blame-ignore-revs.

DblK commented 1 year ago

Just adding my 2cents here, but why adding another linter (djlint) instead of adding a new plugin for eslint for handlebars?

See this plugin.

Flowtter commented 1 year ago

Just adding my 2cents here, but why adding another linter (djlint) instead of adding a new plugin for eslint for handlebars?

See this plugin.

My initial goal was to use a specific linter for each language. That was wrong. I think I'll use Prettier at the end since it has a plugin for handlebars, stylelint, editorconfig and eslint.

Choosing djlint was a poor choice, and I'll take the time to fix this PR ASAP.