Not working on MacOS - Githubissues

l3ony2k / Typora-D42ker-Github-theme

A darker `Github Dark` theme for Typora

25 stars 12 forks source link

Not working on MacOS #1

Open dominikroblek opened 1 year ago

dominikroblek commented 1 year ago

This theme is not working on MacOS: It's not rendered as a dark theme (i.e. white on black) but as a light theme (black on white). Otherwise it looks really nice on MacOS, especially with IBM Plex fonts installed.

Screenshot:

l3ony2k commented 1 year ago

Sorry to hear that! It seems like the theme didn't apply at all. Currently I don't have any macOS devices around so I am not able to look into this issue. PRs are welcome tho.

I have a feeling this might be an easy fix, I'll look into fixing it as soon as I have the chance.

dominikroblek commented 1 year ago

Thank you very much! I think the theme does get applied, just incorrectly. I think so because the fonts do change in comparison to the default Typora's Github theme. But the colors don't change.

Btw, your theme works beautifully on Linux (Ubuntu 22.04) with IBM Plex fonts installed.

l3ony2k commented 1 year ago

Ah good to hear that. Do you have any dark theme that works on macOS? Maybe I can read their code and see what's wrong in mine.

dominikroblek commented 1 year ago

The included Night theme that comes with Typora works fine. A third-party Aspartate theme also works fine.

gastonmorixe commented 1 year ago

Yup still not working in macOS :(

b2aconnn commented 1 year ago

Dark mode does not work on macOS ventura 13.0. The font is so pretty that it would be perfect if dark mode is supported. :)

l3ony2k commented 1 year ago

Currently I still do not have any macOS devices, so it is really difficult for me to test where the problem lies. Perhaps when I have free time, I will try to ask ChatGPT to help me identify the problem. 😢 PRs are still welcome.

BKFlister commented 3 months ago

Try to rename the theme. Works on mine when renaming to for example: darker.css Might be a bug in Typora for Mac, it does not like all characters in the name.

l3ony2k commented 3 months ago

Try to rename the theme. Works on mine when renaming to for example: darker.css Might be a bug in Typora for Mac, it does not like all characters in the name.

Thank you for the information. I will add this suggestion into the README file for broader dissemination.

Serendipity-zyf commented 3 months ago

Try to rename the theme.尝试重命名主题。 Works on mine when renaming to for example: darker.css 重命名为例如 darker.css 时适用于我的 Might be a bug in Typora for Mac, it does not like all characters in the name. 可能是 Mac 版 Typora 中的一个错误，它不喜欢名称中的所有字符。

This is also useful to me !