Closed h1alexbel closed 8 months ago
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.
If this PR solves a todo
from the code, please don't forget to remove it.
@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-06T08:30:25.223586
.
You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.
Estimation here is 30 minutes
, that's how much you will be paid. You will be paid even if this PR gets rejected.
Attention: 4 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
master@b301169
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
...rc/main/java/ru/l3r8y/parser/SuppressedChecks.java | 88.00% | 1 Missing and 2 partials :warning: |
src/main/java/ru/l3r8y/parser/IsSuppressed.java | 85.71% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@l3r8yJ fully agree, but for now I don't know how to do it in a right way, any ideas?
as far as I know, I can check that annotation @SuppressWarnings
exists on top of class, but how to check its value (rule name)?
@l3r8yJ fully agree, but for now I don't know how to do it in a right way, any ideas?
You can look at jtcop implementation of this, I haven't seen it, but I assume there is some object that scans the project only for these exclusions and then during the validation phase just skips these exclusions
It's probably similar to a pattern strategy where Map<Rule, List<Exclusion>>
has a list of class/method names to be skipped in Map<Rule, List<Exclusion>>
against the rule
We can also ask @volodya-lombrozo directly how best to do this?
@l3r8yJ I'm finishing my own implementation, very soon I will submit it
as far as I know, I can check that annotation
@SuppressWarnings
exists on top of class, but how to check its value (rule name)?
I think only with CGLIB
or Reflections
,
CGLIB
if classes don't have interfacesReflections
if classes have interfaces @l3r8yJ take a look, please
@h1alexbel can you please ask for review after all commits? It's a bit struggling to refresh page and look for new diff during review process
The SonarCloud Quality Gate passed, but some issues were introduced.
8 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@l3r8yJ take a look, please
@rultor merge
@rultor merge
@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here
@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.
@l3r8yJ take a look, please closes #38
PR-Codex overview
This PR focuses on adding suppression annotations to the codebase to suppress specific OOP rules.
Detailed summary
@SuppressWarnings
annotation toUser
,SuppressedWorker
,Marked
,Mutable
,Parser
classes.pom.xml
to change the value ofmaximum
from 2 to 4.MethodChangesState.java
to include a link in the complaint message.ClassNames.java
to skip the rule check if the class is suppressed.ClassMethods.java
to skip the method check if the class is suppressed.ErNamedClass
toErSuffixCheck
.ErSuffixCheck
rule to check for classes ending with '-er' suffix.IsSuppressed
class to check if a specific check is suppressed.