search

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

Switch suppression from `@Mutable` to `@SuppressWarning("OOP.MethodChangesState")` #114

Closed l3r8yJ closed 8 months ago

l3r8yJ commented 8 months ago

Also, I suggest renaming the MethodChangesState class to something else

zoeself commented 8 months ago

@l3r8yJ thank you for reporting this. I'll assign someone to take care of it soon.

zoeself commented 8 months ago

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2024-01-13T11:00:26.935134.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

h1alexbel commented 8 months ago

Also, I suggest renaming the MethodChangesState class to something else

@l3r8yJ what about MethodChangesStateCheck? or MethodStateChangeCheck

l3r8yJ commented 8 months ago

@h1alexbel what about MutableStateCheck or MutableStateRule, wdyt?

h1alexbel commented 8 months ago

@l3r8yJ I like MutableStateCheck, added to #113

l3r8yJ commented 8 months ago

@h1alexbel i'll close after #113

h1alexbel commented 8 months ago

@l3r8yJ I think it can be closed

zoeself commented 8 months ago

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.