search

l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

Refactored suppressions release #118

Closed l3r8yJ closed 8 months ago

l3r8yJ commented 8 months ago

Moved suppressions:

  1. From @Mutable to @SuppressedWarnings("OOP.MutableStateCheck")

Added suppressions

  1. @SupressWarnings("OOP.ErSuffixCheck") for classes with -er suffix
zoeself commented 8 months ago

@l3r8yJ thank you for reporting this. I'll assign someone to take care of it soon.

l3r8yJ commented 8 months ago

@rultor release, tag is 0.2.6

zoeself commented 8 months ago

@l3r8yJ this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2024-01-13T16:00:26.745593.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj OK, I will release it now. Please check the progress here

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj Oops, I failed. You can see the full log here (spent 2min)

    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:77\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:568\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
\u001b[1mCaused by\u001b[m: org.apache.maven.reporting.MavenReportException: \u001b[1;31m
Exit code: 1
/home/r/repo/src/main/java/ru/l3r8y/parser/SuppressedChecks.java:40: error: unknown tag: todo
 * @todo #38 This class is too complex.
   ^
/home/r/repo/src/main/java/ru/l3r8y/parser/SuppressedChecks.java:45: error: unknown tag: todo
 * @todo #38 This class lacks off unit testing.
   ^
/home/r/repo/src/main/java/ru/l3r8y/rule/ErSuffixCheck.java:38: error: unknown tag: todo
 * @todo #38 Implement Linked decorator for Rule.
   ^
3 errors
Command line was: /usr/lib/jvm/java-17-openjdk-amd64/bin/javadoc @options @packages

Refer to the generated Javadoc files in '/home/r/repo/target/apidocs' dir.
\u001b[m
    \u001b[1mat\u001b[m org.apache.maven.plugins.javadoc.AbstractJavadocMojo.doExecuteJavadocCommandLine (\u001b[1mAbstractJavadocMojo.java:5197\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeJavadocCommandLine (\u001b[1mAbstractJavadocMojo.java:5070\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport (\u001b[1mAbstractJavadocMojo.java:2029\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugins.javadoc.JavadocJar.doExecute (\u001b[1mJavadocJar.java:181\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugins.javadoc.AbstractJavadocMojo.execute (\u001b[1mAbstractJavadocMojo.java:1825\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (\u001b[1mDefaultBuildPluginManager.java:137\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (\u001b[1mMojoExecutor.java:370\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (\u001b[1mMojoExecutor.java:351\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:215\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:171\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:163\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:117\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:81\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (\u001b[1mSingleThreadedBuilder.java:56\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleStarter.execute (\u001b[1mLifecycleStarter.java:128\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:298\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.execute (\u001b[1mDefaultMaven.java:105\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.execute (\u001b[1mMavenCli.java:960\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.doMain (\u001b[1mMavenCli.java:293\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.main (\u001b[1mMavenCli.java:196\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:77\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:568\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
\u001b[0m\u001b[0mcontainer 7ab0ec0134053cee5637df4d8a246e764975cf73688995a3723118536e0c7845 is dead
Wed Jan  3 05:03:50 PM CET 2024
l3r8yJ commented 8 months ago

@rultor release, tag is 0.2.6

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj OK, I will release it now. Please check the progress here

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj Oops, I failed. You can see the full log here (spent 3min)

    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:117\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:81\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (\u001b[1mSingleThreadedBuilder.java:56\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleStarter.execute (\u001b[1mLifecycleStarter.java:128\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:298\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.execute (\u001b[1mDefaultMaven.java:105\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.execute (\u001b[1mMavenCli.java:960\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.doMain (\u001b[1mMavenCli.java:293\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.main (\u001b[1mMavenCli.java:196\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:77\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:568\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
\u001b[1mCaused by\u001b[m: org.sonatype.nexus.client.core.exception.NexusClientResponseException: \u001b[1;31m502 - Bad Gateway\u001b[m
    \u001b[1mat\u001b[m org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.convert (\u001b[1mJerseyNexusClient.java:276\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.getStatus (\u001b[1mJerseyNexusClient.java:156\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.client.internal.rest.AbstractNexusClient.initializeConnection (\u001b[1mAbstractNexusClient.java:86\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.client.rest.jersey.JerseyNexusClient.<init> (\u001b[1mJerseyNexusClient.java:90\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.client.rest.jersey.NexusClientFactoryImpl.createFor (\u001b[1mNexusClientFactoryImpl.java:125\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.maven.staging.remote.RemoteNexus.createNexusClient (\u001b[1mRemoteNexus.java:193\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.maven.staging.remote.RemoteNexus.<init> (\u001b[1mRemoteNexus.java:102\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.maven.staging.deploy.strategy.AbstractStagingDeployStrategy.createRemoteNexus (\u001b[1mAbstractStagingDeployStrategy.java:58\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.deployPerModule (\u001b[1mStagingDeployStrategy.java:70\u001b[m)
    \u001b[1mat\u001b[m org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute (\u001b[1mDeployMojo.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (\u001b[1mDefaultBuildPluginManager.java:137\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (\u001b[1mMojoExecutor.java:370\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (\u001b[1mMojoExecutor.java:351\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:215\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:171\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:163\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:117\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:81\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (\u001b[1mSingleThreadedBuilder.java:56\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleStarter.execute (\u001b[1mLifecycleStarter.java:128\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:298\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.execute (\u001b[1mDefaultMaven.java:105\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.execute (\u001b[1mMavenCli.java:960\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.doMain (\u001b[1mMavenCli.java:293\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.main (\u001b[1mMavenCli.java:196\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:77\u001b[m)
    \u001b[1mat\u001b[m jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:568\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
\u001b[0m\u001b[0mcontainer 3a4959dba18877b318fd04dc669e0e03fbf1796a1c84f84e7189ec02eb571c66 is dead
Wed Jan  3 05:28:25 PM CET 2024
l3r8yJ commented 8 months ago

@rultor release, tag is 0.2.6

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj OK, I will release it now. Please check the progress here

rultor commented 8 months ago

@rultor release, tag is 0.2.6

@l3r8yj Done! FYI, the full log is here (took me 3min)

zoeself commented 8 months ago

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.