l3r8yJ / oop-cop

The static analysis tool and a Maven plugin that will help you model your objects, classes, methods properly by rejecting your non-perfect code.
https://www.l3r8y.ru/oop-cop/
MIT License
9 stars 5 forks source link

Suppressions for checks, more unit tests #125

Closed h1alexbel closed 8 months ago

h1alexbel commented 8 months ago

closes #85


PR-Codex overview

Detailed summary

The following files were skipped due to too many changes: src/main/java/ru/l3r8y/parser/Default.java, src/main/java/ru/l3r8y/parser/ClassNames.java, src/main/java/ru/l3r8y/parser/IgnoresSuppressed.java, src/test/java/ru/l3r8y/extensions/SuppressedLongClassName.java, src/test/java/ru/l3r8y/parser/DeclarationTest.java, src/test/java/ru/l3r8y/extensions/ParserDeclaration.java, src/test/java/ru/l3r8y/extensions/ManySuppressionsDeclaration.java, src/test/java/ru/l3r8y/parser/DefaultTest.java, src/test/java/ru/l3r8y/parser/SuppressedChecksTest.java, src/test/java/ru/l3r8y/parser/IgnoresSuppressedTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself commented 8 months ago

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

zoeself commented 8 months ago

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-01-08T12:10:03.968245.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c662b88) 76.99% compared to head (59261bc) 78.24%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ============================================ + Coverage 76.99% 78.24% +1.25% - Complexity 70 79 +9 ============================================ Files 18 21 +3 Lines 226 239 +13 Branches 8 10 +2 ============================================ + Hits 174 187 +13 Misses 46 46 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

h1alexbel commented 8 months ago

@l3r8yJ take a look, please

l3r8yJ commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@l3r8yj OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@l3r8yj Done! FYI, the full log is here (took me 2min)

zoeself commented 8 months ago

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.